Repository navigation
fix(overview): show the native fullscreen placeholder where the strip does - #293
Merged
Merged
Conversation
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — Overview fullscreen placeholders now follow the same column ordering as the strip. The PR also removes an existing runtime test, which requires human review even with the new snapshot regression test. Notes:
No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
… does The Overview rebuilt each window's pre-fullscreen slot, so the card stayed in place while the strip moved the placeholder to its end. Read the strip directly; the saved slot still restores the window on exit. Closes #287
qeude
force-pushed
the
fix/overview-fullscreen-placeholder-position
branch
from
November 15, 2026 17:53
fdcce8f to
d416e95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #287
Summary
The Overview rebuilt each native fullscreen window's pre-fullscreen slot, so its card stayed in place while the strip shows the placeholder at the end. The Overview now reads the strip as it is.
logicalOverviewMonitorsis deleted (−110 lines). The saved slot innativeFullscreenTiledPlacementsis untouched, so leaving fullscreen still returns the window to its original column. Overview drop targets now also index the same columns thatapplyOverviewDropresolves them against.Evidence
DaemonOverviewSnapshotTests.overviewShowsFullscreenPlaceholderWhereTheStripDoes: three windows, window 1 enters native fullscreen.[3] [2] [1], Overview[1] [3] [2]→overview == stripfails[3] [2] [1]→ passes;make verifypassesThe old runtime test that asserted the restored-slot projection is removed with the function.
Real daemon (defi-e2e VM, Screen Recording granted): W1 W2 W3 on a fresh workspace, W2 enters native fullscreen, the strip becomes
W1 W3 [W2 placeholder], then the Overview opens.W1 W2 W3, the fullscreen card still between W1 and W3W1 W3 W2, matching the stripProved with the failing-then-passing test above and a before/after recording of both builds in the VM.
Merge Danger
Door: two-way
Blast Radius: Overview
Only how the Overview orders columns that hold a native fullscreen window changes; the strip, fullscreen exit, and parking are unchanged. A fullscreen window that was stacked now shows as its own column at the end, as in the strip. Desktop E2E tests and Computer Use on the maintainer's Mac were not run; the VM recording covers the changed Overview path.
Reviewed with review-loop: 1 round with claude-opus-5-5. Verdict: approved
Note
Show native fullscreen placeholders in overview where the strip does
Daemon.makeOverviewSnapshotnow builds snapshots from runtime monitors directly instead of the logical overview projection. This keeps native fullscreen window placeholders in the same overview columns the strip shows.logicalOverviewMonitorsin OverviewRuntime.swift and the privateOverviewPlacementGroup, along with their tests.Macroscope summarized d416e95.